[Artifact Logging PR3] Add the run_name as a property of the Logger
#700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add a `run_name` as a property of the Logger, and using a coolname to generate it if it is not specifed. Moved this logic out of the wandb logger. 2. Rename `LoggerCallback` to `LoggerDestination`, and update the hparams and trainer init 3. Removed `will_log`. Having this helper added additional complexity, especially since nothing used deferred logging. Instead, individual callbacks can implement filtering as they see fit. 4. Renamed `log_metric` to `log_data`. Metric is a confusing name, as it can easily be confused with TorchMetrics, and the logger is not limited to TorchMetrics. Similarly, renamed `metric_fit`, `metric_epoch`, and `metric_batch` to `data_fit`, `data_epoch`, and `data_batch`. 5. Removed deep copying of the logging data in the base logger class. It turned out that only the InMemoryLogger needed this functionality, and it copies its own data.
jbloxham
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
run_nameas a property of the Logger, and using a coolname to generate it if it is not specified. Moved this logic out of the wandb logger, since it can be useful for every logger. See Artifact Logging for the spec.CC @abhi-mosaic