Updated contributing.md and the style guide #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal imports, and running tests.
ravi-mosaicml
changed the title
|
Should we merge style guide and contributing together? |
I was thinking the same thing haha...let's do it then :) |
|
Looks like I'm a few steps behind -- review no longer needed, correct? In other words, you're going to merge the files and open a new PR... or update this PR with the files merged, and then review will be needed? |
I updated the PR with the requested changes....if you could give it a review that would be awesome! |
dblalock
reviewed
Mar 8, 2022
|
@dblalock I updated the files as discussed offline. |
dblalock
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added information on docstrings, conditional imports, and running tests.