-
Notifications
You must be signed in to change notification settings - Fork 454
Jenkins + Docker Improvements #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Set the ephemeral storage limit; switch to useing command v2 to run tests. 2. Add the build discarder config to the Jenkinsfile 3. Re-enable the conda builds. It's slow -- I know -- but it only runs whenever the dependencies (setup.py or meta.yaml) changes. 4. Not installing node globally in the dockerfile.
…omposer into ravi/jenkinsfile_improvements
hanlint
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command2
to run tests, which supports the ephemeral storage k8s parameter and adds timestamp markings to build. Ephemeral storage should prevent tests from non-deterministically running out of disk space, since now K8S will ensure that the node has this much space available.merge
target instead ofhead
. Closes Switch to/merge
instead of/head
for forked PRs #268.pullRequest
variable so it doesn't crash when it's not defined. Also skipping (most) checks on the merge commit, since there is no need to re-run them.