Supporting Mixed Init on FSDP2 #3872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithwik-db
changed the title
rithwik-db
changed the title
rithwik-db
commented
Jun 4, 2025
rithwik-db
commented
Jun 4, 2025
dakinggg
reviewed
Jun 5, 2025
dakinggg
reviewed
Jun 5, 2025
dakinggg
reviewed
Jun 5, 2025
dakinggg
reviewed
Jun 5, 2025
dakinggg
reviewed
Jun 5, 2025
bowenyang008
reviewed
Jun 6, 2025
bowenyang008
reviewed
Jun 6, 2025
bowenyang008
reviewed
Jun 6, 2025
bowenyang008
reviewed
Jun 6, 2025
bowenyang008
reviewed
Jun 6, 2025
bowenyang008
reviewed
Jun 6, 2025
bowenyang008
reviewed
Jun 6, 2025
made some changes some changes lets see if this works formatted small fix some more changes test changes formatted hopefully works formatted addressed comments formatted undid some unnecessary changes things hangs otherwise updated with better formatting got some more tests working moved to class formatted fixed small bugs used settable attrs minor changes
bowenyang008
reviewed
Jun 6, 2025
bowenyang008
reviewed
Jun 6, 2025
bowenyang008
reviewed
Jun 6, 2025
bowenyang008
reviewed
Jun 6, 2025
bowenyang008
reviewed
Jun 6, 2025
bowenyang008
reviewed
Jun 6, 2025
bowenyang008
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supporting mixed init on FSDP2.