-
Notifications
You must be signed in to change notification settings - Fork 454
FSDP2 time and verbose logging #3856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dakinggg when do we use Composer custom Loggers and when do we use generic python logging module? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please leave MCLI run name in the "manual testing" section of the PR description so it is easy for reviewer to double check and refer back to. Unless run name includes sensitive info, in which case you can DM it to reviewer.
@bowenyang008 Composer loggers need to be used if you want to log to an experiment tracker (mlflow, wandb, etc). We also have a custom logger for the MCLI platform, and custom loggers for progress bar logging and "pretty" training progress console logging. But for general debugging/info statements, just use python logging. |
Oh, I just tested locally on my dev machine as the PR is simple enough so I just need to make sure it logs the info to console correctly. But here is a MCLI run I just kicked off: mpt-7b-fsdp2-G2eJiP
|
Ah fair enough. Yeah its nice, to launch a run for posterity (although this is obviously a very minor change) |
What does this PR do?
Support logging of FSDP2 execution time, wrapped model and verbose config
Test
Tested manually, see: mpt-7b-fsdp2-G2eJiP