Skip to content

Conversation

bowenyang008
Copy link
Contributor

@bowenyang008 bowenyang008 commented Apr 25, 2025

What does this PR do?

Remove dead code which is only effective before torch 2.4, which we don't support anymore.

What issue(s) does this change relate to?

  1. Pave the way to support and release torch 2.7 and deprecate torch 2.4/2.5
  2. Test Cursor on trivial SDE task

Changes by AI coder

Most changes are created by Cursor, yet reviewed by myself. Workflow:
Codebase wise one shot change is still hard for Cursor, so current flow is:

1. Use agent mode in Cursor
2. Use Claude 3.7 non-thinking
3. 
For file in target_files:
    prompt("currently we support torch versions between 2.4 and 2.6, can you help me apply necessary changes to remove or clean up code related to torch version less than 2.4 in this @file? Please don't modify other comments or docstrings. When you need to delete a function please consider if it is used by other files in @composer as well.")

@bowenyang008 bowenyang008 changed the title clean up state Eliminate dead code before torch version 2.4 Apr 28, 2025
@bowenyang008 bowenyang008 marked this pull request as ready for review April 28, 2025 21:33
@bowenyang008 bowenyang008 requested a review from a team as a code owner April 28, 2025 21:33
@bowenyang008 bowenyang008 merged commit d8686f6 into main Apr 29, 2025
14 checks passed
@bowenyang008 bowenyang008 deleted the boweny/cursor/version-cleanup branch April 29, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants