Activation Checkpointing and Offloading for FSDP2 #3832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithwik-db
commented
Apr 25, 2025
rithwik-db
force-pushed
the
activation_checkpointing
branch
from
92e948a to
470b3d7
Compare
rithwik-db
commented
Apr 29, 2025
rithwik-db
force-pushed
the
activation_checkpointing
branch
from
f047d18 to
beee38f
Compare
rithwik-db
commented
Apr 29, 2025
rithwik-db
changed the title
dakinggg
approved these changes
May 1, 2025
bowenyang008
reviewed
May 1, 2025
bowenyang008
reviewed
May 1, 2025
bowenyang008
reviewed
May 1, 2025
bowenyang008
reviewed
May 1, 2025
bowenyang008
reviewed
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding activation checkpointing and activation cpu offloading using the same method as TorchTitan in their examples (which aligns with our previous approach using
checkpoint_wrapper)Added tests to check if checkpointing and cpu offloading is working as expected.