Update optimizer params for fsdp2 #3822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithwik-db
commented
Apr 16, 2025
dakinggg
reviewed
Apr 17, 2025
dakinggg
reviewed
Apr 17, 2025
dakinggg
reviewed
Apr 17, 2025
rithwik-db
force-pushed
the
optimizer-inplace
branch
from
de43ee2 to
ce53bbc
Compare
rithwik-db
changed the title
bowenyang008
approved these changes
Apr 22, 2025
|
LGTM as well. |
|
Just FYI, I'm pretty sure the new code does not have this issue, but one quirk of the FSDP1 impl: #2320 |
rithwik-db
changed the title
rithwik-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR to update optimizer params to point to dtensors instead of regular model tensors. This should work fine for checkpointing as well since we fully shard before updating the optimizer's state (which is referenced in
update_optimizer_modules)