Skip to content

Conversation

irenedea
Copy link
Contributor

What does this PR do?

With this change, we no longer need to explicitly set the WORLD_SIZE when running make test on machines with >1 GPUs

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@irenedea irenedea requested a review from a team as a code owner March 18, 2025 01:29
@irenedea irenedea enabled auto-merge (squash) March 18, 2025 01:29
@irenedea irenedea merged commit dce0460 into main Mar 18, 2025
14 checks passed
@irenedea irenedea deleted the irene/world-size-test branch March 18, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants