Skip to content

Lower min torchmetrics version #3691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

Lower min torchmetrics version #3691

merged 1 commit into from
Oct 29, 2024

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Lower min torchmetrics version. #3460 raised it and we instead intend to stay no >1.0

@mvpatel2000 mvpatel2000 requested a review from a team as a code owner October 29, 2024 14:18
@mvpatel2000 mvpatel2000 requested a review from dakinggg October 29, 2024 14:18
@mvpatel2000 mvpatel2000 mentioned this pull request Oct 29, 2024
Closed
dakinggg
dakinggg approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, cause if CI passes than lgtm, but CI is not passing

@mvpatel2000 mvpatel2000 merged commit e33c9e3 into main Oct 29, 2024
14 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000-patch-1 branch October 29, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dakinggg dakinggg dakinggg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @dakinggg