Skip to content

Don't overwrite sys.excepthook in mlflow logger #3675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Don't overwrite sys.excepthook in mlflow logger #3675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions composer/loggers/mlflow_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,10 @@ def _start_mlflow_run(self, state):
)
self.monitor_process.start()

def _global_exception_handler(self, exc_type, exc_value, exc_traceback):
def _global_exception_handler(self, original_excepthook, exc_type, exc_value, exc_traceback):
"""Catch global exception."""
self._global_exception_occurred += 1
sys.__excepthook__(exc_type, exc_value, exc_traceback)
original_excepthook(exc_type, exc_value, exc_traceback)

def init(self, state: State, logger: Logger) -> None:
del logger # unused
Expand All @@ -322,7 +322,13 @@ def init(self, state: State, logger: Logger) -> None:
self.run_name += f'-rank{dist.get_global_rank()}'

# Register the global exception handler so that uncaught exception is tracked.
sys.excepthook = self._global_exception_handler
original_excepthook = sys.excepthook
sys.excepthook = lambda exc_type, exc_value, exc_traceback: self._global_exception_handler(
original_excepthook,
exc_type,
exc_value,
exc_traceback,
)
# Start run
if self._enabled:
self._start_mlflow_run(state)
Expand Down
Loading