Skip to content

Conversation

eitanturok
Copy link
Contributor

@eitanturok eitanturok commented Sep 27, 2024

What does this PR do?

Disables tensor parallelism when the tensor_parallelism_degree is 1.

This is a cleaner version of #3437 that passes all the tests.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@eitanturok eitanturok merged commit 566d262 into mosaicml:main Sep 27, 2024
14 checks passed
@eitanturok eitanturok deleted the tp_1_degree branch September 27, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants