Skip to content

Add backward compatibility checkpoint tests for v0.25.0 #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Add backward compatibility checkpoint tests for v0.25.0 #3635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77ef5ab
update version
Sep 24, 2024
6d049ed
update
Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/trainer/test_fsdp_checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,7 @@ def test_fsdp_mixed_with_sync(
'0.22.0',
'0.23.0',
'0.24.0',
'0.25.0',
],
)
@pytest.mark.filterwarnings(r'ignore:.*metrics are not saved with sharded state dict.*:UserWarning')
Expand All @@ -532,8 +533,9 @@ def test_fsdp_load_old_checkpoint(
if composer_version == '0.18.1' and state_dict_type == 'full' and precision == 'amp_bf16' and sharding_strategy == 'FULL_SHARD':
pytest.skip('TODO: This checkpoint is missing')

if (composer_version in ['0.22.0', '0.23.0'] and version.parse(torch.__version__) < version.parse('2.3.0')
) or (composer_version == '0.24.0' and version.parse(torch.__version__) < version.parse('2.4.0')):
if (composer_version in ['0.22.0', '0.23.0'] and version.parse(torch.__version__) < version.parse('2.3.0')) or (
composer_version == '0.24.0' and version.parse(torch.__version__) < version.parse('2.4.0')
) or (composer_version == '0.25.0' and version.parse(torch.__version__) < version.parse('2.5.0')):
pytest.skip('Current torch version is older than torch version that checkpoint was written with.')

if composer_version in ['0.13.5', '0.14.0', '0.14.1', '0.15.1']:
Expand Down
Loading