Don't init dist when world_size is 1 #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbloxham
commented
Jan 31, 2022
Co-authored-by: ravi-mosaicml <[email protected]>
A-Jacobson
pushed a commit
that referenced
this pull request
Feb 10, 2022
* cleanup dist init * specify node rank * rewrite _get_distributed_config_var for better error handling * change a warning to an error * woops * dummy commit to trigger jenkins * Update composer/utils/dist.py Co-authored-by: ravi-mosaicml <[email protected]> * woops * remove print statement Co-authored-by: ravi-mosaicml <[email protected]>
coryMosaicML
pushed a commit
to coryMosaicML/composer
that referenced
this pull request
Feb 23, 2022
* cleanup dist init * specify node rank * rewrite _get_distributed_config_var for better error handling * change a warning to an error * woops * dummy commit to trigger jenkins * Update composer/utils/dist.py Co-authored-by: ravi-mosaicml <[email protected]> * woops * remove print statement Co-authored-by: ravi-mosaicml <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distributed process group doesn't necessarily need to be initialized when we're doing single-process training, and this can help avoid crashes in certain environments. Note that the DDP initialization code already is a no-op when the distributed process group is not initialized.
Tested by running models with various world sizes (and no explicit world size), and using a print statement to verify whether the model was the original model class or a DDP wrapper.