Remove secrets from the yaml #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched the object store provider to take `key_environ` and `secret_environ` instead of `key` and `secret`, so secrests are not stored in the config and instead must be specified via env variables.
|
I can confirm that this works. To confirm that secrets aren't logged, see this WandB run, and you can view that the secrets aren't shown. To confirm that the run directory is still uploaded properly, this GCS link shows the YAML that corresponds with the WandB run. Overall, LGTM. Great work getting that in so quickly @ravi-mosaicml! |
moinnadeem
approved these changes
Jan 22, 2022
hanlint
approved these changes
Jan 22, 2022
|
We will merge this after the CI/CD re-run is finished. |
coryMosaicML
pushed a commit
to coryMosaicML/composer
that referenced
this pull request
Feb 23, 2022
Switched the object store provider to take `key_environ` and `secret_environ` instead of `key` and `secret`, so secrests are not stored in the config and instead must be specified via env variables. Co-authored-by: hanlint <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched the object store provider to take
key_environandsecret_environinstead ofkeyandsecret, so secrets are not stored in the config and instead must be specified via env variables.Closes #242