Skip to content

Conversation

bandish-shah
Copy link
Contributor

@bandish-shah bandish-shah commented Nov 1, 2022

What does this PR do?

User's reported an issue where manually updating packages in our Docker images could lead to unintended PyTorch upgrades if any supporting PyTorch packages (e.g., torchaudo, torchtext, torchvision) are installed without a version specification.

This PR implements a workaround in our Composer PyPi package and Docker images that should pin the Torch version to what we've tested and the Docker images to the specific version we built them for.

What issue(s) does this change relate to?

Resolves CO-1367

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@bandish-shah bandish-shah requested a review from a team as a code owner November 1, 2022 23:26
@bandish-shah bandish-shah enabled auto-merge (squash) November 3, 2022 18:21
@bandish-shah bandish-shah changed the title Explicitly pin PyTorch versions Pin PyTorch and supporting package versions Nov 3, 2022
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you've tested. Can we open a jira for 1.13? Has some important bugfixes

@bandish-shah bandish-shah merged commit c53b200 into mosaicml:dev Nov 4, 2022
@bandish-shah bandish-shah deleted the bandish/pin_pytorch branch November 4, 2022 00:41
bandish-shah added a commit to bandish-shah/composer that referenced this pull request Nov 10, 2022
* Bound torch to < 1.13
* Updated Docker flow to pin torchtext version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants