Skip to content

Defaulting streaming dataset version to 2 #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2022
Merged

Defaulting streaming dataset version to 2 #1616

merged 3 commits into from
Oct 14, 2022

Conversation

karan6181
Copy link
Contributor

What does this PR do?

  • Defaulting streaming dataset version to 2

What issue(s) does this change relate to?

Fixes: CO-1244

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@karan6181 karan6181 requested review from a team and knighton as code owners October 12, 2022 05:17
bandish-shah
bandish-shah approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@bandish-shah bandish-shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karan6181 karan6181 requested a review from a team as a code owner October 12, 2022 18:42
@karan6181 karan6181 enabled auto-merge (squash) October 14, 2022 17:57
@karan6181 karan6181 merged commit 56f0e33 into mosaicml:dev Oct 14, 2022
@karan6181 karan6181 deleted the streaming_v2_default branch October 14, 2022 18:15
@karan6181 karan6181 mentioned this pull request Oct 14, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bandish-shah bandish-shah bandish-shah approved these changes

+1 more reviewer

@knighton knighton knighton approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karan6181 @knighton @bandish-shah