Skip to content

Conversation

eracah
Copy link
Contributor

@eracah eracah commented Oct 8, 2022

What does this PR do?

  • logs num_nodes and num_gpus_per_node or num_cpus_per_node.
  • enables hyperparameter logging for ProgressBar
  • adds a unit test to check num_gpus_per_node is set properly

What issue(s) does this change relate to?

fixes CO-1224

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a Jira issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@eracah eracah marked this pull request as ready for review October 8, 2022 00:43
@eracah eracah merged commit 65527d4 into mosaicml:dev Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants