Skip to content

Simplify helper for conflicting files #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 22, 2022
Merged

Simplify helper for conflicting files #1427

merged 4 commits into from
Aug 22, 2022

Conversation

hanlint
Copy link
Contributor

@hanlint hanlint commented Aug 19, 2022

  • Simplifies the helper function
  • Removes checks for _in_epoch conflicts, since its not possible for files to have the same batch counter, but have different epoch_in_batch counters.

@hanlint hanlint requested a review from mvpatel2000 August 19, 2022 02:27
mvpatel2000
mvpatel2000 reviewed Aug 22, 2022
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot cleaner! I'm not sure if we can skip the _in_epoch though -- see comment.

mvpatel2000
mvpatel2000 approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock

@hanlint hanlint merged commit 1cb3d4d into mosaicml:dev Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanlint @mvpatel2000