Skip to content

Conversation

alextrott16
Copy link
Contributor

Uses evaluation logic pseudocode to provide a better intuition for the logic and the relationship between ComposerModel.validate and ComposerModel.metrics.

Adds some exposition around using the Evaluators class.

Closes CO-861

@alextrott16 alextrott16 requested a review from hanlint August 11, 2022 17:44
@alextrott16 alextrott16 requested a review from a team as a code owner August 11, 2022 17:44
@alextrott16
Copy link
Contributor Author

@hanlint Not sure if this addresses all the aspects of CO-861, but AFAICT the validate method should be the same regardless of what style of metric it feeds into (i.e., the output tuple from validate will always be used as the positional arguments for metric.update regardless of whether it represents a single metric or a list-style or dict-style metric collection).

Copy link
Contributor

@hanlint hanlint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, perhaps that last section is can be changed to include psueodcode? Otherwise, looks good to me.

@alextrott16 alextrott16 requested a review from hanlint August 23, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants