Skip to content

fix(NODE-4518): error message with invalid authMechanism is provided #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2023
Merged

fix(NODE-4518): error message with invalid authMechanism is provided #3597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/connection_string.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ export function parseOptions(
) {
// If authSource was explicitly given and its incorrect, we error
throw new MongoParseError(
`${mongoOptions.credentials} can only have authSource set to '$external'`
`authMechanism ${mongoOptions.credentials.mechanism} requires an authSource of '$external'`
);
}

Expand Down
12 changes: 12 additions & 0 deletions test/unit/connection_string.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,18 @@ describe('Connection String', function () {
expect(options).to.not.have.property('credentials');
});

for (const mechanism of ['GSSAPI', 'MONGODB-X509']) {
context(`when the authMechanism is ${mechanism} and authSource is NOT $external`, function () {
it('throws a MongoParseError', function () {
expect(() =>
parseOptions(`mongodb+srv://hostname/?authMechanism=${mechanism}&authSource=invalid`)
)
.to.throw(MongoParseError)
.to.match(/requires an authSource of '\$external'/);
});
});
}

it('should omit credentials and not throw a MongoAPIError if the only auth related option is authSource', async () => {
// The error we're looking to **not** see is
// `new MongoInvalidArgumentError('No AuthProvider for ${credentials.mechanism} defined.')`
Expand Down