Skip to content

feat(NODE-5016)!: compile ts with target es2020 #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2023
Merged

feat(NODE-5016)!: compile ts with target es2020 #3545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"root": true,
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 2019
"ecmaVersion": 2020
},
"plugins": [
"simple-import-sort",
Expand Down
14 changes: 10 additions & 4 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@
"checkJs": false,
"strict": true,
"alwaysStrict": true,
"target": "ES2019",
"target": "ES2020",
"module": "commonJS",
"moduleResolution": "node",
"skipLibCheck": true,
"lib": ["es2020"],
"lib": [
"es2020"
],
Comment on lines +11 to +13
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is prettier's doing, lmk if we want to omit

// We don't make use of tslib helpers, all syntax used is supported by target engine
"importHelpers": false,
"noEmitHelpers": true,
Expand All @@ -25,7 +27,9 @@
// we include sources in the release
"inlineSources": false,
// Prevents web types from being suggested by vscode.
"types": ["node"],
"types": [
"node"
],
"forceConsistentCasingInFileNames": true,
"noImplicitOverride": true,
"noImplicitReturns": true,
Expand All @@ -36,5 +40,7 @@
"transpileOnly": true,
"compiler": "typescript-cached-transpile"
},
"include": ["src/**/*"]
"include": [
"src/**/*"
]
}