RUST-2078 Support QE with bulk write #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
isabelatkinson
force-pushed
the
bulk-write-qe
branch
from
d1f4e71 to
d752bd4
Compare
abr-egn
reviewed
Aug 28, 2025
src/bson_util.rs
Outdated
| fn push(&mut self, doc: RawDocumentBuf); | ||
|
|
||
| /// Adds the collection of raw documents to the provided command. | ||
| fn add_to_command(self, identifier: &'static CStr, command: &mut Command); |
There was a problem hiding this comment.
Extremely minor nit: I don't think this needs the 'static?
There was a problem hiding this comment.
it does not, updated!
src/operation/bulk_write.rs
Outdated
| let index = self.cache.len(); | ||
| let bytes_added = T::bytes_added(index, &namespace_doc)?; | ||
| self.pending_namespace = Some(namespace_doc); | ||
| self.cache.insert(namespace, index); |
There was a problem hiding this comment.
I know in current usage it doesn't matter because a pending document not being added terminates the outer loop, but it still bugs me that the namespace is added to the cache even if add_pending is never called. Not sure what a good way to fix that would be, though.
There was a problem hiding this comment.
updated to defer adding to the cache til add_pending is called
abr-egn
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements mongodb/specifications#1770