Skip to content

RUST-2104 Add From trait for SocketAddr to ServerAddress #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 13, 2025
Merged

RUST-2104 Add From trait for SocketAddr to ServerAddress #1396

merged 6 commits into from
Jun 13, 2025

Conversation

JamieTsai1024
Copy link
Contributor

Implemented and updated tests for to convert std::net::SocketAddr to ServerAddress (Tcp variant) using the From trait

@JamieTsai1024 JamieTsai1024 marked this pull request as ready for review June 10, 2025 19:58
@JamieTsai1024 JamieTsai1024 requested a review from a team as a code owner June 10, 2025 19:58
@JamieTsai1024 JamieTsai1024 requested a review from abr-egn June 10, 2025 19:58
@isabelatkinson isabelatkinson requested review from isabelatkinson and removed request for abr-egn June 10, 2025 20:30
isabelatkinson
isabelatkinson reviewed Jun 10, 2025
View reviewed changes
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far! a few minor suggestions

isabelatkinson
isabelatkinson reviewed Jun 10, 2025
View reviewed changes
@isabelatkinson isabelatkinson changed the title Rust 2104 Add From trait for SocketAddr to ServerAddress RUST-2104 Add From trait for SocketAddr to ServerAddress Jun 10, 2025
isabelatkinson
isabelatkinson approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! going to tag in Abraham for review as well

@isabelatkinson isabelatkinson requested a review from abr-egn June 11, 2025 15:31
abr-egn
abr-egn approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JamieTsai1024 JamieTsai1024 merged commit 061c490 into mongodb:main Jun 13, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abr-egn abr-egn abr-egn approved these changes

@isabelatkinson isabelatkinson isabelatkinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamieTsai1024 @abr-egn @isabelatkinson