Skip to content

RUST-2191 Fix type propagation for Aggregate::session #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

RUST-2191 Fix type propagation for Aggregate::session #1353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/action/aggregate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ impl<'a, T> Aggregate<'a, ImplicitSession, T> {
pub fn session(
self,
value: impl Into<&'a mut ClientSession>,
) -> Aggregate<'a, ExplicitSession<'a>> {
) -> Aggregate<'a, ExplicitSession<'a>, T> {
Aggregate {
target: self.target,
pipeline: self.pipeline,
Expand Down Expand Up @@ -265,3 +265,20 @@ impl AggregateTargetRef<'_> {
}
}
}

#[test]
fn aggregate_session_type() {
// Assert that this code compiles but do not actually run it.
#[allow(
unreachable_code,
unused_variables,
dead_code,
clippy::diverging_sub_expression
)]
fn compile_ok() {
let agg: Aggregate = todo!();
let typed: Aggregate<'_, _, ()> = agg.with_type::<()>();
let mut session: ClientSession = todo!();
let typed_session: Aggregate<'_, _, ()> = typed.session(&mut session);
}
}