RUST-2171 Update rustls to 0.23
#1322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
requested changes
Mar 6, 2025
There was a problem hiding this comment.
@ctz thank you for this PR! A few changes requested:
- There is a failure in the CI lint task. Can you run
cargo +1.84 clippy && cargo +1.84 clippy --all-featuresand fix? (see.evergreen/check-clippy.shfor the CI script) - The latest commit to
mainincludes a fix to our MSRV task. Can you please merge/rebase so that we can run the MSRV task properly to check if this new version complies with our MSRV? If not, we may need to bump it.
I can also make and push these changes to your branch if you'd prefer.
rustls 0.21 is EOL for security support at the end of March 2025. - Drop rustls-pemfile, as it is now incorporated into rustls-pki-types; use the new iterator-based API. - Use the ring-based provider, to align with previous version's build-time requirements.
|
Rebased and fixed the clippy lint. |
isabelatkinson
requested changes
Mar 10, 2025
abr-egn
approved these changes
Mar 10, 2025
Co-authored-by: Isabel Atkinson <[email protected]>
isabelatkinson
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
@ctz thanks again for your contribution! I'll merge this once CI has finished running
|
Thanks for using rustls! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustls 0.21 is EOL for security support at the end of March 2025.