Skip to content

GODRIVER-3038 Add todo comments #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2023
Merged

GODRIVER-3038 Add todo comments #1452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b3f657
GODRIVER-3038 Add todo comments
prestonvasquez Nov 2, 2023
4869f31
GODRIVER-3038 Make comments operation-specific
prestonvasquez Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions mongo/index_view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ func (iv IndexView) List(ctx context.Context, opts ...*options.ListIndexesOption
description.LatencySelector(iv.coll.client.localThreshold),
})
selector = makeReadPrefSelector(sess, selector, iv.coll.client.localThreshold)

// TODO(GODRIVER-3038): This operation should pass CSE to the ListIndexes
// Crypt setter to be applied to the operation.
op := operation.NewListIndexes().
Session(sess).CommandMonitor(iv.coll.client.monitor).
ServerSelector(selector).ClusterClock(iv.coll.client.clock).
Expand Down Expand Up @@ -251,6 +254,10 @@ func (iv IndexView) CreateMany(ctx context.Context, models []IndexModel, opts ..

option := options.MergeCreateIndexesOptions(opts...)

// TODO(GODRIVER-3038): This operation should pass CSE to the CreateIndexes
// Crypt setter to be applied to the operation.
//
// This was added in GODRIVER-2413 for the 2.0 major release.
op := operation.NewCreateIndexes(indexes).
Session(sess).WriteConcern(wc).ClusterClock(iv.coll.client.clock).
Database(iv.coll.db.name).Collection(iv.coll.name).CommandMonitor(iv.coll.client.monitor).
Expand Down Expand Up @@ -387,6 +394,9 @@ func (iv IndexView) drop(ctx context.Context, name string, opts ...*options.Drop
selector := makePinnedSelector(sess, iv.coll.writeSelector)

dio := options.MergeDropIndexesOptions(opts...)

// TODO(GODRIVER-3038): This operation should pass CSE to the DropIndexes
// Crypt setter to be applied to the operation.
op := operation.NewDropIndexes(name).
Session(sess).WriteConcern(wc).CommandMonitor(iv.coll.client.monitor).
ServerSelector(selector).ClusterClock(iv.coll.client.clock).
Expand Down