Skip to content

[Fix] disable new command not updating db config #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2023
Merged

[Fix] disable new command not updating db config #3278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
003edcd
[Fix] disable new command not updating
martinbndr Apr 11, 2023
5e09346
Merge branch 'development' into fix-disable-command
Taaku18 Jul 15, 2023
ba7ce40
Update changelog
Taaku18 Jul 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ however, insignificant breaking changes do not guarantee a major version bump, s
- Guild icons in embed footers and author urls now have a fixed size of 128. ([PR #3261](https://github.com/modmail-dev/modmail/pull/3261))
- Discord.py internal logging is now enabled by default. ([PR #3216](https://github.com/modmail-dev/Modmail/pull/3216))
- The confirm-thread-creation dialog now uses buttons instead of reactions. ([PR #3273](https://github.com/modmail-dev/Modmail/pull/3273))
- `?disable all` no longer overrides `?disable new`. ([PR #3278](https://github.com/modmail-dev/Modmail/pull/3278))

### Internal
- Renamed `Bot.log_file_name` to `Bot.log_file_path`. Log files are now created at `temp/logs/modmail.log`. ([PR #3216](https://github.com/modmail-dev/Modmail/pull/3216))
Expand Down
2 changes: 1 addition & 1 deletion cogs/modmail.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2152,7 +2152,7 @@ async def disable_new(self, ctx):
description="Modmail will not create any new threads.",
color=self.bot.main_color,
)
if self.bot.config["dm_disabled"] < DMDisabled.NEW_THREADS:
if self.bot.config["dm_disabled"] != DMDisabled.NEW_THREADS:
self.bot.config["dm_disabled"] = DMDisabled.NEW_THREADS
await self.bot.config.update()

Expand Down