Skip to content

Conversation

ihrpr
Copy link
Contributor

@ihrpr ihrpr commented Oct 2, 2025

run prettier after #976

@ihrpr ihrpr requested review from a team, dsp-ant and pcarleton October 2, 2025 17:19
Comment on lines +15 to +29
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
cache: npm

- run: npm ci
- run: npm run build
- run: npm test
- run: npm run lint

publish:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 9 days ago

To fix the issue, we should explicitly set a permissions block so that the build job receives only those privileges necessary for its steps—in this case, likely just read access to repository contents. Following least privilege principles, we should set permissions: contents: read at the build job level (since the publish job already has a tighter block) to ensure both jobs use the minimum required scope. No changes elsewhere are needed.

  • Add the following block under build: in .github/workflows/main.yml, above runs-on:
        permissions:
          contents: read
  • No imports, methods, or definitions needed.

Suggested changeset 1
.github/workflows/main.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -12,6 +12,8 @@
 
 jobs:
     build:
+        permissions:
+            contents: read
         runs-on: ubuntu-latest
 
         steps:
EOF
@@ -12,6 +12,8 @@

jobs:
build:
permissions:
contents: read
runs-on: ubuntu-latest

steps:
Copilot is powered by AI and may make mistakes. Always verify output.
}));
app.use(
cors({
origin: '*', // Allow all origins - adjust as needed for production

Check warning

Code scanning / CodeQL

Permissive CORS configuration Medium

CORS Origin allows broad access due to
permissive or user controlled value
.
@ihrpr ihrpr merged commit 1150b1d into main Oct 2, 2025
5 checks passed
@ihrpr ihrpr deleted the ihrpr/prettier branch October 2, 2025 17:21
SVLaursen pushed a commit to SVLaursen/typescript-sdk that referenced this pull request Oct 7, 2025
Copy link

@76hy55bcwt-ux 76hy55bcwt-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello world
Aspex 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants