Skip to content

chore: Update radix-ui components and icons #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 25, 2025
Merged

chore: Update radix-ui components and icons #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
336804d
Update @radix-ui/react-checkbox
richardkmichael Jun 24, 2025
6d8e2dd
Update @radix-ui/react-label
richardkmichael Jun 24, 2025
21d3b7d
Update @radix-ui/react-tabs
richardkmichael Jun 24, 2025
54209f4
Update @radix-ui/react-tooltip
richardkmichael Jun 24, 2025
0987127
Update @radix-ui/react-toast
richardkmichael Jun 24, 2025
8153f0d
Update @radix-ui/react-dialog
richardkmichael Jun 24, 2025
5d00e87
Update @radix-ui/react-popover
richardkmichael Jun 24, 2025
e0fe311
Update @radix-ui/react-select
richardkmichael Jun 24, 2025
73bb000
Update lucide-react
richardkmichael Jun 24, 2025
36e053a
Adjust e2e test configuration
richardkmichael Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/e2e_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ on:

jobs:
test:
timeout-minutes: 5
# Installing Playright dependencies can take quite awhile, and also depends on GitHub CI load.
timeout-minutes: 15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I am kind of surprised that CI might take this long for these tests. Wonder if this should only run on main or on demand?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can run on all PRs, as-is.

The actual tests take only ~25 seconds. A total test run is ~3m20s. Both visible on this successful run.

The failed run exceeded the timeout during runner prep; apt-get update and Playwright install w deps took > 4 minutes. I'm not sure, but presume this depends on cache state and GitHub infrastructure load, so the minimum is difficult to predict. 10 minutes might be enough, I set it to 15 to avoid fiddling with it. :-)

Ideally the author runs locally too. Personally, I prefer to have full test suites enabled for PRs / branches, to avoid discovering breakage after a merge. If the test suite is slow, that ought to be dealt with.

runs-on: ubuntu-latest

steps:
Expand Down Expand Up @@ -44,11 +45,12 @@ jobs:
if: steps.cache-playwright.outputs.cache-hit != 'true'

- name: Run Playwright tests
id: playwright-tests
run: npm run test:e2e

- name: Upload Playwright Report and Screenshots
uses: actions/upload-artifact@v4
if: always()
if: steps.playwright-tests.conclusion != 'skipped'
with:
name: playwright-report
path: |
Expand All @@ -59,7 +61,7 @@ jobs:

- name: Publish Playwright Test Summary
uses: daun/playwright-report-summary@v3
if: always()
if: steps.playwright-tests.conclusion != 'skipped'
with:
create-comment: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
report-file: client/results.json
Expand Down
2 changes: 1 addition & 1 deletion client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"class-variance-authority": "^0.7.0",
"clsx": "^2.1.1",
"cmdk": "^1.0.4",
"lucide-react": "^0.447.0",
"lucide-react": "^0.523.0",
"pkce-challenge": "^4.1.0",
"prismjs": "^1.30.0",
"react": "^18.3.1",
Expand Down
Loading