GroupNorm implementation #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parameter happens to be on the gpu. The failure is caused due to the two parts being concatenated not being on the same device. By default, torch.ones creates the tensor on the cpu. So, if the coord happens to be on gpu, the error occurs. Fixed by creating the torch.ones tensor on the same device as the coord.
…e chances of bucket overflow error happening in hashmap.cu. When n is small, the effect of uneven distribution of hash values is more pronounced, and we select the table size to be 4 * nextPow2 and for larger n, we take it to be 2 * nextPow2. This way, for larger n, when memory size consideration is more important, the table_size gets computed to be same as it used to be.
…parameter happens to be on the gpu. The failure is caused due to the two parts being concatenated not being on the same device. By default, torch.ones creates the tensor on the cpu. So, if the coord happens to be on gpu, the error occurs. Fixed by creating the torch.ones tensor on the same device as the coord.
…e chances of bucket overflow error happening in hashmap.cu. When n is small, the effect of uneven distribution of hash values is more pronounced, and we select the table size to be 4 * nextPow2 and for larger n, we take it to be 2 * nextPow2. This way, for larger n, when memory size consideration is more important, the table_size gets computed to be same as it used to be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for GroupNorm.