Smaller Tests - make avoidNonLinks test smaller. One assert per test. #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to deal with failures. Before, if the first line in the data file failed, none of the subsequent lines would run. Now every line will always run, and you can get clear output of which ones passed and which ones failed!
|
The Travis failure is PHP 5.3 problem that would be fixed by #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to deal with failures.
Before, if the first line in the data file failed, none of the subsequent lines would run.
Now every line will always run, and you can get clear output of which ones passed and which ones failed!
If you approve, this could be applied to the other tests to.