Skip to content

Conversation

mikbry
Copy link
Owner

@mikbry mikbry commented Dec 17, 2019

Fix issues

Description

Refactor ZipEntry code and move in 'proceed' function

Check List

  • respect code conventions and usages
  • tests and 100% coverage
  • well documented
  • self review

Review targets:

  • nodejs / npm / yarn

@mikbry mikbry self-assigned this Dec 17, 2019
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          83     86    +3     
=====================================
+ Hits           83     86    +3
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️
src/ZipEntry.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea24f28...4abdfbd. Read the comment docs.

@mikbry mikbry merged commit 28617c6 into master Dec 17, 2019
@mikbry mikbry deleted the feat_refactor_zipentry branch December 17, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant