Make VSTest repo buildable in VMR non-source-build #4920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nohwnd merged 7 commits into main from MakeVSTestBuildInVMR

Mar 6, 2024

Member

ViktorHofer commented Mar 6, 2024 •

edited

Loading

Contributes to dotnet/source-build#4030

DotNetBuildFromSource -> DotNetBuildSourceOnly
DotNetBuildFromSourceFlavor -> DotNetBuildOrchestrator
SourceBuild.props -> DotNetBuild.props
AfterSolutionBuild.targets: Add a condition as runtime download currently doesn't work inside the VMR


          Make VSTest repo buildable in VMR unified-build

45bc738

ViktorHofer requested a review from mmitche

March 6, 2024 15:28

ViktorHofer requested review from nohwnd and Evangelink as code owners

March 6, 2024 15:28

mmitche reviewed

View reviewed changes

Directory.Build.targets Outdated Show resolved Hide resolved

mmitche reviewed

View reviewed changes

Directory.Build.targets Outdated Show resolved Hide resolved

mmitche reviewed

View reviewed changes

src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj Outdated Show resolved Hide resolved

mmitche reviewed

View reviewed changes

src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj Outdated Show resolved Hide resolved

mmitche reviewed

View reviewed changes

src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj Outdated Show resolved Hide resolved

mmitche reviewed

View reviewed changes

src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj Outdated Show resolved Hide resolved

mmitche approved these changes

View reviewed changes

Member

mmitche left a comment

Changes otherwise look good. Should at least be straight compatible in source-build mode.

ViktorHofer and others added 6 commits

March 6, 2024 16:41


          Update Directory.Build.targets

3d88c28

Co-authored-by: Matt Mitchell <[email protected]>


          Update Directory.Build.targets

4826d45

Co-authored-by: Matt Mitchell <[email protected]>


          Update src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.…

d2976cc

…csproj

Co-authored-by: Matt Mitchell <[email protected]>


          Update src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.…

86079ed

…csproj

Co-authored-by: Matt Mitchell <[email protected]>


          Update src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.…

d380ae7

…CLI.csproj

Co-authored-by: Matt Mitchell <[email protected]>


          Update src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.…

ae2e78d

…CLI.csproj

Co-authored-by: Matt Mitchell <[email protected]>

nohwnd approved these changes

View reviewed changes

nohwnd enabled auto-merge (squash)

March 6, 2024 16:55

nohwnd merged commit 82c581f into main

nohwnd deleted the MakeVSTestBuildInVMR branch

March 6, 2024 17:25

renovate bot mentioned this pull request

chore(deps): update nuget packages aneoconsulting/ArmoniK.Api#390

Merged

1 task

This was referenced Oct 1, 2025

Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0 Jahbrael/skills-secure-repository-supply-chain#10

Open

Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0 paulinathrasher/skills-secure-repository-supply-chain#10

Open

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#847

Closed

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#848

Closed

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#849

Closed

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#856

Closed

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#863

Closed

build: Bump Microsoft.NET.Test.Sdk from 17.5.0 to 17.14.1 apimatic/core-lib-csharp#152

Open

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#869

Closed

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#882

Closed

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#889

Closed

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#901

Closed

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#917

Closed

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#920

Closed

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#933

Closed

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#934

Closed

Bump Microsoft.NET.Test.Sdk from 17.2.0 to 17.13.0 Azure-Gforce/docs#943

Open

Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0 NFraley13/skills-secure-repository-supply-chain#10

Open

Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0 jumainfomagnus/skills-secure-repository-supply-chain#11

Open

Bump Microsoft.NET.Test.Sdk from 17.9.0 to 18.0.0 Soshmitha/ScanaRepoTest#15

Open

Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0 c41057079/skills-secure-repository-supply-chain#8

Open

fix: Bump Microsoft.NET.Test.Sdk from 17.8.0 to 18.0.0 aftabphb043/FizzBuzz#9

Open

Bump Microsoft.NET.Test.Sdk from 17.8.0 to 18.0.0 philipp2604/S7Scanner#26

Open

Bump the unittest-dependencies group with 5 updates QTNetModernization-5000-Repos/MvvmCross_1#33

Open

Bump Microsoft.NET.Test.Sdk from 17.8.0 to 18.0.0 BillChirico/GolfClapBot#46

Open

chore: Bump Microsoft.NET.Test.Sdk from 17.8.0 to 18.0.0 followthewhiterabbitneo/ARIAredsharpie#21

Open

Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0 aniketkgr/skills-secure-repository-supply-chain#10

Open

Bump the tests group with 3 updates devlooped/Mvp.Xml#121

Open

Bump Microsoft.NET.Test.Sdk from 17.6.0 to 17.13.0 viklover/Telegram.Bot.Extensions.MessageBuilder#2

Open

Bump Microsoft.NET.Test.Sdk from 17.8.0 to 18.0.0 Tim-Maes/Facet#78

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet