CPPTools fails to query clang++ (ndk)

[thunderstorm010]

Bug type: Language Service

Describe the bug

• OS and Version: Windows 10 20H2 (19042)
• VS Code Version: 1.56.1
• C/C++ Extension Version: 1.3.1
• A clear and concise description of what the bug is, including information about the workspace (i.e. is the workspace a single project or multiple projects, size of the project, etc).
  IntelliSense fails to query the clang++ compiler from NDK. This results on IntelliSense falling back to win32 and cl.exe. I've also opened an issue in CMake Tools Repo.
  Because of this, there are squiggles under android system includes.

Expected behavior
No red squiggles under android system includes.

Logs
https://gist.github.com/thunderstorm010/fcf90394f7da1c3feb18b11d4ca671b7
https://gist.github.com/thunderstorm010/a25ed5e3a49935d685ef90385e5716bf

[Colengms]

Hi @thunderstorm010 . I'm seeing the following in your log output:

clang++: error: unsupported option '-fPIC' for target 'x86_64-w64-windows-gnu'

The command line it was attempting to run at the time was:

"q:/android-ndk-r22b/toolchains/llvm/prebuilt/windows-x86_64/bin/clang++.exe" -g -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -Wformat -Werror=format-security -O0 -fno-limit-debug-info -fPIC -std=gnu++20 -g -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -Wformat -Werror=format-security -O0 -fno-limit-debug-info -fPIC --sysroot=Q:/android-ndk-r22b/toolchains/llvm/prebuilt/windows-x86_64/sysroot  -Wp,-v -E -dD -x c++  -fno-blocks nul

Since we do not add -fPIC when querying the compiler, the issue would seem to be due either to this being an invalid arg, or because another arg needs to be included (that was perhaps omitted from the command line by the C/C++ extension) which modifies how other args are interpreted. Or, perhaps due to the order of those args.

Could you confirm that you're able to build despite using this arg? If so, could you compare the command line above with the command line generated by your build, and let us know the differences? ( -Wp,-v -E -dD -x c++ -fno-blocks nul is being added by us).

[thunderstorm010]

I can build the project as usual with no errors using Ninja.

[Colengms]

@thunderstorm010 I assume because your project targets android that you are not intending to compile for x86_64-w64-windows-gnu. Could you enable verbose output for CMake and provide one of your compile command lines? A compile command line from compile_commands.json would also work. Perhaps an arg that controls the target used by the compiler is being omitted by the compiler query. Seeing a working compile command line for your project should clarify.

[searingarrows]

I had the same issue and temporally fixed it by removing all "-Wa,--noexecstack" options in my compile_commands.json.

The logs are as follows (I don't know how to make it in English).
cpp.log

[sean-mcmanus]

@searingarrows I believe your issue is fixed in 1.4.0-insiders (same issue as #7388 ).

@thunderstorm010 Have you tried 1.4.0-insiders? It's possible your issue may also be caused by the -Werror, but the logging doesn't directly indicate that.

[searingarrows]

@sean-mcmanus 1.4.0-insiders works, thanks

[thunderstorm010]

@thunderstorm010 I assume because your project targets android that you are not intending to compile for x86_64-w64-windows-gnu. Could you enable verbose output for CMake and provide one of your compile command lines? A compile command line from compile_commands.json would also work. Perhaps an arg that controls the target used by the compiler is being omitted by the compiler query. Seeing a working compile command line for your project should clarify.

How can I do that? I'm using CMake and I can't see the compile_commands.json file.

[sean-mcmanus]

@thunderstorm010 You can set the CMAKE_EXPORT_COMPILE_COMMANDS CMake variable to have CMake generate a compile_commands.json file. In VS Code there's a CMake.LoggingLevel setting (not sure if that's what Colen meant by the "enable verbose output").

[thunderstorm010]

My compile_commands.json file:

[
{
  "directory": "C:/Users/crypto/Desktop/New folder/MonoLoader/build/Quest",
  "command": "Q:\\android-ndk-r22b\\toolchains\\llvm\\prebuilt\\windows-x86_64\\bin\\clang++.exe --target=aarch64-none-linux-android24 --gcc-toolchain=Q:/android-ndk-r22b/toolchains/llvm/prebuilt/windows-x86_64 --sysroot=Q:/android-ndk-r22b/toolchains/llvm/prebuilt/windows-x86_64/sysroot -DID=\\\"monoloader\\\" -DVERSION=\\\"0.1.0\\\" -Dmonoloader_EXPORTS -I../../extern -I../../shared -I../../include -I../.././extern/libil2cpp/il2cpp/libil2cpp -isystem ../../extern/beatsaber-hook/shared -isystem ../../extern/modloader -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security   -O0 -fno-limit-debug-info  -fPIC -std=gnu++20 -o CMakeFiles\\monoloader.dir\\src\\main.cpp.o -c \"C:\\Users\\crypto\\Desktop\\New folder\\MonoLoader\\src\\main.cpp\"",
  "file": "C:/Users/crypto/Desktop/New folder/MonoLoader/src/main.cpp"
},
{
  "directory": "C:/Users/crypto/Desktop/New folder/MonoLoader/build/Quest",
  "command": "Q:\\android-ndk-r22b\\toolchains\\llvm\\prebuilt\\windows-x86_64\\bin\\clang++.exe --target=aarch64-none-linux-android24 --gcc-toolchain=Q:/android-ndk-r22b/toolchains/llvm/prebuilt/windows-x86_64 --sysroot=Q:/android-ndk-r22b/toolchains/llvm/prebuilt/windows-x86_64/sysroot -DID=\\\"monoloader\\\" -DVERSION=\\\"0.1.0\\\" -Dmonoloader_EXPORTS -I../../extern -I../../shared -I../../include -I../.././extern/libil2cpp/il2cpp/libil2cpp -isystem ../../extern/beatsaber-hook/shared -isystem ../../extern/modloader -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security   -O0 -fno-limit-debug-info  -fPIC -std=gnu++20 -o CMakeFiles\\monoloader.dir\\extern\\beatsaber-hook\\src\\inline-hook\\And64InlineHook.cpp.o -c \"C:\\Users\\crypto\\Desktop\\New folder\\MonoLoader\\extern\\beatsaber-hook\\src\\inline-hook\\And64InlineHook.cpp\"",
  "file": "C:/Users/crypto/Desktop/New folder/MonoLoader/extern/beatsaber-hook/src/inline-hook/And64InlineHook.cpp"
},
{
  "directory": "C:/Users/crypto/Desktop/New folder/MonoLoader/build/Quest",
  "command": "Q:\\android-ndk-r22b\\toolchains\\llvm\\prebuilt\\windows-x86_64\\bin\\clang.exe --target=aarch64-none-linux-android24 --gcc-toolchain=Q:/android-ndk-r22b/toolchains/llvm/prebuilt/windows-x86_64 --sysroot=Q:/android-ndk-r22b/toolchains/llvm/prebuilt/windows-x86_64/sysroot -DID=\\\"monoloader\\\" -DVERSION=\\\"0.1.0\\\" -Dmonoloader_EXPORTS -I../../extern -I../../shared -I../../include -I../.././extern/libil2cpp/il2cpp/libil2cpp -isystem ../../extern/beatsaber-hook/shared -isystem ../../extern/modloader -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security  -O0 -fno-limit-debug-info  -fPIC -o CMakeFiles\\monoloader.dir\\extern\\beatsaber-hook\\src\\inline-hook\\inlineHook.c.o -c \"C:\\Users\\crypto\\Desktop\\New folder\\MonoLoader\\extern\\beatsaber-hook\\src\\inline-hook\\inlineHook.c\"",
  "file": "C:/Users/crypto/Desktop/New folder/MonoLoader/extern/beatsaber-hook/src/inline-hook/inlineHook.c"
},
{
  "directory": "C:/Users/crypto/Desktop/New folder/MonoLoader/build/Quest",
  "command": "Q:\\android-ndk-r22b\\toolchains\\llvm\\prebuilt\\windows-x86_64\\bin\\clang.exe --target=aarch64-none-linux-android24 --gcc-toolchain=Q:/android-ndk-r22b/toolchains/llvm/prebuilt/windows-x86_64 --sysroot=Q:/android-ndk-r22b/toolchains/llvm/prebuilt/windows-x86_64/sysroot -DID=\\\"monoloader\\\" -DVERSION=\\\"0.1.0\\\" -Dmonoloader_EXPORTS -I../../extern -I../../shared -I../../include -I../.././extern/libil2cpp/il2cpp/libil2cpp -isystem ../../extern/beatsaber-hook/shared -isystem ../../extern/modloader -g -DANDROID -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security  -O0 -fno-limit-debug-info  -fPIC -o CMakeFiles\\monoloader.dir\\extern\\beatsaber-hook\\src\\inline-hook\\relocate.c.o -c \"C:\\Users\\crypto\\Desktop\\New folder\\MonoLoader\\extern\\beatsaber-hook\\src\\inline-hook\\relocate.c\"",
  "file": "C:/Users/crypto/Desktop/New folder/MonoLoader/extern/beatsaber-hook/src/inline-hook/relocate.c"
}
]

[Colengms]

Hi @thunderstorm010 . If you remove "configurationProvider": "ms-vscode.cmake-tools" from your c_cpp_properties.json, and instead set "compileCommands": "<path to your compile_commands.json file>", does the issue still occur?

The command lines in your compile_commands.json file include --target args, but I am not seeing any --target args in the custom configuration data received from CMake Tools. If that compile_commands.json was generated using the same CMake configuration that you were using with CMake Tools in the logs you posted, the issue would seem to be that CMake Tools is not passing the --target arg along to the C/C++ Extension for some reason.

[sean-mcmanus]

i.e. if CMake Tools isn't sending the --target you could file an issue with CMake Tools or we could transfer this issue there.