Normalize drive letter on windows for presets expanision #2665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes is a workaround for microsoft/vscode#156781
The following changes are proposed:
When expanding macros for CmakePresets.json on windows, the drive letter will now be re-normalized to uppercase.
The purpose of this change
When access
workspaceFolder
by uri, VScode normalize drive letter on windows to lowercase for historical reason. This behavior will cause all expanded path start with a lowercase drive letter, while Visual Studio, at the same time, expanding it as uppercase. If a user is switching vscode and Visual Studio, they would have to regenerate cmake cache as cmake count all those paths as a different variables.Other Notes/Information