Remove problematic environment variables from the debugger environment #2496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| test('No variable expansion env vars', () => { | ||
| const env: {[key: string]: string} = {}; | ||
| env['foo'] = 'bar'; | ||
| env['other'] = '${hey'; |
There was a problem hiding this comment.
A question: So our assumption is that all the env variables are resolved by this point, and if they are not (or if not expanded), we just don't send them to the debugger?
There was a problem hiding this comment.
Yes. The output of makeDebuggerEnvironmentVars gets put into the environment of the debug config object and sent to VS Code. I call fromDebuggerEnvironmentVars to convert it into a dictionary object that's easier to validate.
elahehrashedi
approved these changes
Apr 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2442