Skip to content

Build log always shows source directory even when using out of source builds #3308

@an3l

Description

@an3l

Brief Issue Summary

When build the project using out of source build directory (vscode-build ), log still shows source directory (10.11 below)

[main] Building folder: 10.11
[build] Starting build
[proc] Executing command: /usr/local/bin/cmake --build /home/anel/GitHub/mariadb/server/build/vscode-build --config Debug --target all --

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

From file cmakeProject.js can be seen that only current folderName is used (source directory). It should be binaryDir IMHO.

Suggested fix should be

log.info(localize('run.build', 'Building folder: {0}', this.binaryDir ? this.binaryDir : this.folderName ), (targets && targets.length > 0) ? targets.join(', ') : '');

Metadata

Metadata

Assignees

Labels

Feature: buildbuga bug in the producthelp wantedwe currently are not planning work on this and would like help from the open source communityquick fixthe fix is estimated to be quicksuggestedTemporary label for internal tracking for suggested bugs to pick up in spare time.

Type

No type

Projects

Status

Completed

Relationships

None yet

Development

No branches or pull requests

Issue actions