-
Notifications
You must be signed in to change notification settings - Fork 502
Closed
Labels
Feature: buildbuga bug in the producta bug in the producthelp wantedwe currently are not planning work on this and would like help from the open source communitywe currently are not planning work on this and would like help from the open source communityquick fixthe fix is estimated to be quickthe fix is estimated to be quicksuggestedTemporary label for internal tracking for suggested bugs to pick up in spare time.Temporary label for internal tracking for suggested bugs to pick up in spare time.
Milestone
Description
Brief Issue Summary
When build the project using out of source build directory (vscode-build
), log still shows source directory (10.11
below)
[main] Building folder: 10.11
[build] Starting build
[proc] Executing command: /usr/local/bin/cmake --build /home/anel/GitHub/mariadb/server/build/vscode-build --config Debug --target all --
CMake Tools Diagnostics
No response
Debug Log
No response
Additional Information
From file cmakeProject.js can be seen that only current folderName is used (source directory). It should be binaryDir
IMHO.
Suggested fix should be
log.info(localize('run.build', 'Building folder: {0}', this.binaryDir ? this.binaryDir : this.folderName ), (targets && targets.length > 0) ? targets.join(', ') : '');
Metadata
Metadata
Assignees
Labels
Feature: buildbuga bug in the producta bug in the producthelp wantedwe currently are not planning work on this and would like help from the open source communitywe currently are not planning work on this and would like help from the open source communityquick fixthe fix is estimated to be quickthe fix is estimated to be quicksuggestedTemporary label for internal tracking for suggested bugs to pick up in spare time.Temporary label for internal tracking for suggested bugs to pick up in spare time.
Type
Projects
Status
Completed