Project using kits and variants doesn't work in 1.13.40

[xisui-MSFT]

Brief Issue Summary

Project using kits and variants doesn't work in 1.13.40

1. Create a CMake project without presets, in which case it should fall back to kits and variants.
2. Open project in VS Code and notice that the tool bar doesn't switch to kits and variants view, and none of the configure / build related commands work.
3. Multi-root with kits and variants doesn't work as well, not sure if that's also caused by this though.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response

[elahehrashedi]

This is the project that repro the issue:
azure-sphere-samples/Samples/HelloWorld/HelloWorld_HighLevelApp at main · Azure/azure-sphere-samples (github.com)

[elahehrashedi]

@xisui-MSFT
Here are the steps to repro the issue using this example: https://github.com/Azure/azure-sphere-samples/tree/main/Samples/HelloWorld/HelloWorld_HighLevelApp

1 . The project includes preset files and the status bar is showing the preset related buttons.

2. If you go to settings.json and add "cmake.useCMakePresets": "never", the status bar will get updated to kits and variants, because we track the changes in settings.
4. I assume you are deleting the preset files for the project to fall back into kits and variants. Deleting the files doesn't automatically make the project fall back into using kits (which it should), and you need to reload the window to make that happen.

The only way I am able to repro your issue is by deleting the preset files. Would you please verify if that is how you end up with this bug? if yes, then this won't be a regression, we have to check when files are being deleted from the project and if the deleted files are preset files and "cmake.useCMakePresets": "auto", we have to fall back into kits.

[elahehrashedi]

We are going to add a rename or delete event listener for CMakeLists.txt . We can add the presets files to the event listener as well (for the cases where "cmake.useCMakePresets" is set to "auto".

Look at onDidRenameFiles events from here : https://github.com/microsoft/vscode-cmake-tools/pull/2946/files

[xisui-MSFT]

Ah yeah I was using an old version of that sample... So the actual steps:

1. Remove presets file from the project so it uses kits/variants.
2. Install Azure Sphere SDK: https://aka.ms/AzureSphereSDKDownload/Windows
3. Install Azure Sphere extension in VS Code
4. Open the project

I believe the reason this issue repros is that the Azure Sphere extension calls the following commands on activation, and causes a deadlock:

• cmake.setKitByName
• cmake.launchTargetPath
• cmake.hideLaunchCommand
• cmake.hideDebugCommand

We can add the presets files to the event listener as well (for the cases where "cmake.useCMakePresets" is set to "auto".

I remember I wrote this? I'm probably wrong though since that's a long time ago.

[elahehrashedi]

By following the steps, I am able to see the kit menu in the status bar (in both situations where Azure Sphere extension is installed or not).

however, after installing your extension, I see this and I am not able to configure correctly:

[elahehrashedi]

I used another project with a CMakeLists.txt as below and I am able to configure without setting the kits:

CMAKE_MINIMUM_REQUIRED(VERSION 3.20)
PROJECT(CMakeSample C)

azsphere_configure_tools(TOOLS_REVISION "22.11")
azsphere_configure_api(TARGET_API_SET "15")