1.8.0 release ignores cmake.configureOnOpen setting

[xikxp1]

Brief Issue Summary

Newest 1.8.0 release ignores "cmake.configureOnOpen" setting. Every time I reload my workspace cmake reconfiguration happens.

Expected:

1. Open workspace with "cmake.configureOnOpen": false in workspace settings
2. Cmake configure doesn't happen

Apparent Behavior:

1. Open workspace with "cmake.configureOnOpen": false in workspace settings
2. Extension runs cmake configure

CMake Tools Log

[variant] Loaded new set of variants
[kit] Successfully loaded 6 kits from /home/xikxp1/.local/share/CMakeTools/cmake-tools-kits.json
[proc] Executing command: /usr/bin/clang-7 -v
[main] Configuring folder: uservices 
[cmake] C compiler: /usr/bin/clang-7
[cmake] C++ compiler: /usr/bin/clang++-7
[cmake] Using LLVM lld linker
[cmake] LTO: ON
[cmake] LTO_CACHE: ON in folder /home/xikxp1/uservices-build/build/.ltocache
[cmake] ccache: enabled
[cmake] variant: 1
[cmake] Boost version: 1.58.0
[cmake] Checking -Wdisabled-optimization
[cmake] Checking -Wdisabled-optimization - found
[cmake] Checking -Winvalid-pch
[cmake] Checking -Winvalid-pch - found
[cmake] Checking -Wlogical-op
[cmake] Checking -Wlogical-op - not found
[cmake] Checking -Wuseless-cast
[cmake] Checking -Wuseless-cast - not found
[cmake] Checking -Wformat=2
[cmake] Checking -Wformat=2 - found
[cmake] Checking -Wno-error=deprecated-declarations
[cmake] Checking -Wno-error=deprecated-declarations - found
[cmake] Checking -ftemplate-depth=200
[cmake] Checking -ftemplate-depth=200 - found
[cmake] Checking -Wimplicit-fallthrough
[cmake] Checking -Wimplicit-fallthrough - found
[cmake] boost: 105800
[cmake] Python: /usr/lib/yandex/taxi-py3-2/bin/python3
[cmake] Checking python requirements: /home/xikxp1/arc/arcadia/taxi/uservices
[cmake] Checking python requirements: /home/xikxp1/arc/arcadia/taxi/uservices/testsuite
[cmake] Checking python requirements: /home/xikxp1/arc/arcadia/taxi/uservices/userver/submodules/codegen
[cmake] Python: /usr/lib/yandex/taxi-py3-2/bin/python3
[cmake] Run userver codegen ...
[cmake] Failed to retrive git short hash
[cmake] Userver version 1.0.0
[cmake] Boost version: 1.58.0
[cmake] Found the following Boost libraries:
[cmake]   program_options
[cmake]   filesystem
[cmake]   locale
[cmake]   thread
[cmake]   regex
[cmake]   iostreams
[cmake]   system
[cmake]   chrono
[cmake]   date_time
[cmake]   atomic
[cmake] Installed version libyandex-taxi-curl4-openssl-dev: 7.68.0-10
[cmake] Using libyandex-taxi-curl status: ON
[cmake] Installed version libfmt-dev: 7.1.3
[cmake] Installed version libhttp-parser-dev: 2.9.2-1.1taxi1
[cmake] Boost version: 1.58.0
[cmake] Found /usr/lib/gcc/x86_64-linux-gnu/4.9.3/include/backtrace.h
[cmake] Context impl: fcontext
[cmake] Boost version: 1.58.0
[cmake] Run uservices codegen ...
[cmake] BUILD_TYPE: Debug
[cmake] Configuring service: �[32mcontractor-orders-multioffer�[m
[cmake] Boost version: 1.58.0
[cmake] Found the following Boost libraries:
[cmake]   regex
[cmake] Project yandex-taxi-contractor-orders-multioffer
[cmake] Checking python requirements: /home/xikxp1/arc/arcadia/taxi/uservices/services/contractor-orders-multioffer
[cmake] Configuring service: �[32mdriver-orders-app-api�[m
[cmake] Boost version: 1.58.0
[cmake] Found the following Boost libraries:
[cmake]   regex
[cmake] Project yandex-taxi-driver-orders-app-api
[cmake] Checking python requirements: /home/xikxp1/arc/arcadia/taxi/uservices/services/driver-orders-app-api
[cmake] Configuring service: �[32mdriver-orders-builder�[m
[cmake] Boost version: 1.58.0
[cmake] Found the following Boost libraries:
[cmake]   regex
[cmake] Project yandex-taxi-driver-orders-builder
[cmake] Checking python requirements: /home/xikxp1/arc/arcadia/taxi/uservices/services/driver-orders-builder
[cmake] Installed version libyandex-taxi-yt-wrapper-dev: 7551643
[cmake] Root path for /home/xikxp1/arc/arcadia/taxi/uservices/userver/grpc/src/tests/unit_test.proto is /home/xikxp1/arc/arcadia/taxi/uservices/userver/grpc/src/tests. Rel path 
[cmake] Installed version libyandex-taxi-mongo-c-driver-dev: 1.17.2-2
[cmake] Installed version libyandex-taxi-mongo-c-driver-dev: 1.17.2-2
[cmake] Boost version: 1.58.0
[cmake] Found the following Boost libraries:
[cmake]   regex
[cmake] Installed version libpq-dev: 12.3-1.pgdg16.04+1
[cmake] Installed version libpq-dev: 12.3-1.pgdg16.04+1
[cmake] Installed version libhiredis-dev: 0.13.3-2.4
[cmake] Boost version: 1.58.0
[cmake] Found the following Boost libraries:
[cmake]   thread
[cmake]   chrono
[cmake]   system
[cmake]   date_time
[cmake]   atomic
[cmake] Boost version: 1.58.0
[cmake] Found the following Boost libraries:
[cmake]   program_options
[cmake] Testsuite single target mode
[cmake] Configuring done
[cmake] Generating done

Platform and Versions

• Operating System: Ubuntu 16.04
• CMake Version: 3.12.1
• VSCode Version: 1.59.1
• CMake Tools Extension Version: 1.8.0
• Compiler/Toolchain: Clang 7.1.0

Other Notes/Information

When I roll back to extension version 1.7.3 everything works as expected.

[bobbrow]

Thank you for reporting this issue. A fix is in PR. If you would like to help us test it, here are instructions:

1. Download the zip file from here: https://github.com/microsoft/vscode-cmake-tools/suites/3633828779/artifacts/87986211
2. Unzip the VSIX file inside.
3. Run the "Install from VSIX..." command in VS Code and select the unzipped VSIX file.

We plan to patch this soon, but the PR build should unblock you until then.

[xikxp1]

Thanks, @bobbrow! The provided fix worked for me.

[bobbrow]

Thank you very much for confirming!

[bobbrow]

Version 1.8.1 has this fix and was released today.