Clear out checker-level stacks on pop #1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that entries in checker-level stacks are explicitly zeroed out when popped to prevent memory leaks.
- Clears the last
TypeResolutionentry before slicing inpopTypeResolution - Clears the last
ContextualInfoentry before slicing inpopContextualType - Clears the last
InferenceContextInfoentry before slicing inpopInferenceContext
jakebailey
commented
Jul 7, 2025
Comment on lines
+29358
to
+29360
| lastIndex := len(c.contextualInfos) - 1 | ||
| c.contextualInfos[lastIndex] = ContextualInfo{} | ||
| c.contextualInfos = c.contextualInfos[:lastIndex] |
There was a problem hiding this comment.
This is honestly better written slices.Delete, which also nils things out, but, whatever
DanielRosenwasser
approved these changes
Jul 7, 2025
RyanCavanaugh
approved these changes
Jul 7, 2025
|
Long term we should just have a |
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
zshannon
pushed a commit
to zshannon/typescript-go
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See microsoft/TypeScript#62016, #1358 (comment)