Skip to content

Add copy results return value #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Add copy results return value #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f89df13
add copy results return value
cssuh Sep 8, 2023
1b6f235
add change in main
cssuh Sep 8, 2023
f2e8519
remove r
cssuh Sep 8, 2023
e83ae43
fix return value
cssuh Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/azdata.proposed.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,6 +863,13 @@ declare module 'azdata' {
selections: SelectionRange[];
}

export interface CopyResultsRequestResult {
/**
* Result string from copy operation
*/
results: string;
}

export interface QueryProvider {
/**
* Notify clients that the URI for a connection has been changed.
Expand All @@ -874,7 +881,7 @@ declare module 'azdata' {
* ADS will use this if 'supportCopyResultsToClipboard' property is set to true in the provider contribution point in extension's package.json.
* Otherwise, The default handler will load all the selected data to ADS and perform the copy operation.
*/
copyResults?(requestParams: CopyResultsRequestParams): Thenable<void>;
copyResults?(requestParams: CopyResultsRequestParams): Thenable<CopyResultsRequestResult>;
}

export enum DataProviderType {
Expand Down
4 changes: 2 additions & 2 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,9 +564,9 @@ export class QueryFeature extends SqlOpsFeature<undefined> {
);
};

let copyResults = (params: azdata.CopyResultsRequestParams): Thenable<void> => {
let copyResults = (params: azdata.CopyResultsRequestParams): Thenable<azdata.CopyResultsRequestResult> => {
return client.sendRequest(protocol.CopyResultsRequest.type, params).then(
r => undefined,
r => r,
e => {
client.logFailedRequest(protocol.CopyResultsRequest.type, e);
return Promise.reject(e);
Expand Down
2 changes: 1 addition & 1 deletion src/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ export namespace SaveResultsAsXmlRequest {
// --------------------------------- < Copy Results Request > ------------------------------------------
// copy results to clipboard
export namespace CopyResultsRequest {
export const type = new RequestType<azdata.CopyResultsRequestParams, void, void, void>('query/copy');
export const type = new RequestType<azdata.CopyResultsRequestParams, azdata.CopyResultsRequestResult, void, void>('query/copy');
}
// --------------------------------- </ Copy Results Request > ------------------------------------------

Expand Down