Remove duplicated types #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
commented
Apr 25, 2023
|
|
||
| let registerOnConnectionChanged = (handler: (changedConnInfo: azdata.ChangedConnectionInfo) => any): void => { | ||
| client.onNotification(protocol.ConnectionChangedNotification.type, (params: protocol.ConnectionChangedParams) => { | ||
| handler({ |
There was a problem hiding this comment.
This is the only actual "change" in this PR - if for some reason the object we got passed had additional properties on it then we would now be passing those along to the provider. But this isn't how the rest of the handlers are set up anyways - and since this is coming from the server side we have control over that for MSSQL (and other providers shouldn't be sending additional data anyways).
alanrenmsft
approved these changes
Apr 25, 2023
alanrenmsft
pushed a commit
that referenced
this pull request
Jun 9, 2023
* Remove duplicated types * Remove max line length
Merged
alanrenmsft
added a commit
that referenced
this pull request
Jun 9, 2023
* Remove duplicated types (#85) * Remove duplicated types * Remove max line length * add copy result to query provider (#86) * add copy result to query provider * fix error * update js --------- Co-authored-by: Charles Gagnon <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while investigating something else - but we currently have a large amount of "duplicated" types in here. These are types which are already defined in azdata (usually due to them being exposed as provider callbacks).
There isn't any reason I can think of to have these extra ones here - they just add extra overhead to remember to update (and often times that step is missed). And the way that this library uses them is just as types, the original objects passed in are always going to be their azdata counterparts.
So I went through and removed a bunch that I saw. It's likely I missed a couple, but this makes it a lot cleaner and then we can just be better in the future about keeping an eye on what types are used/updated here and remove others we see as being unnecessary down the line.
I'm not planning on doing a new release for these since this stuff should all have no change on the existing behavior.