fix(ui mode): filter dialog positioning #37619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
commented
Sep 27, 2025
| onMouseDown={preventDefault}> | ||
| {icons.settings()} | ||
| </a> | ||
| <Dialog |
There was a problem hiding this comment.
It is important that anchor ref is placed in the DOM before the Dialog. Otherwise, React does not have it initialized by the time we measure the ref.
dgozman
force-pushed
the
fix-dialog-positioning
branch
2 times, most recently
from
4af1041 to
8e56339
Compare
This comment has been minimized.
This comment has been minimized.
agg23
approved these changes
Sep 29, 2025
Dialog position logic did not account for the viewport size. To fix this, copy logic from highlight.ts that does it for tooltips.
dgozman
force-pushed
the
fix-dialog-positioning
branch
from
8e56339 to
2ad7d51
Compare
Test results for "tests 1"4 flaky46931 passed, 821 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialog position logic did not account for the viewport size. To fix this, copy logic from highlight.ts that does it for tooltips.
This issue was reported here.
Dirve-by: make dialog measure its width instead of hardcoding 200, make
useMeasure()return the full rect, not just size.