Logging in framework.cc should use the session logger #3043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
previously approved these changes
Feb 19, 2020
ybrnathan
previously approved these changes
Feb 19, 2020
ybrnathan
previously approved these changes
Feb 19, 2020
snnn
requested changes
Feb 19, 2020
yufenglee
force-pushed
the
roli/rel-1.1.2
branch
from
8ef5f80 to
8c87edf
Compare
pranavsharma
approved these changes
Feb 19, 2020
|
You'll need 2 reviewers to sign-off since this is for the release branch. |
snnn
approved these changes
Feb 19, 2020
|
/azp run Linux CPU x64 NoContribops CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Win CPU x64 NoContribops CI Pipeline |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Describe your changes.
Use session logger for logging in framework.cc
Motivation and Context
default logger action can not be controller by the log level option in SessionOption