Skip to content

fix: Parse list flags correctly #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix: Parse list flags correctly #543

merged 1 commit into from
Jul 25, 2024

Conversation

shueybubbles
Copy link
Collaborator

Handle multiple -i and -v entries correctly when they are followed by a flag-without-space like -isomefile1 somefile2 -V10

apoorvdeshmukh
apoorvdeshmukh approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@apoorvdeshmukh apoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shueybubbles shueybubbles merged commit 5532ff3 into main Jul 25, 2024
@shueybubbles shueybubbles deleted the dev/davidshi/fixflags branch July 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvdeshmukh apoorvdeshmukh apoorvdeshmukh approved these changes

@stuartpa stuartpa Awaiting requested review from stuartpa

+1 more reviewer

@dlevy-msft dlevy-msft dlevy-msft approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shueybubbles @apoorvdeshmukh @dlevy-msft @stuartpa