Skip to content

Implement connect command and password prompt #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2022
Merged

Implement connect command and password prompt #51

merged 3 commits into from
Mar 8, 2022

Conversation

shueybubbles
Copy link
Collaborator

:Connect implementation uses the same command line parser as main. I've added a -G to enable AAD auth.
I've also created a Console interface to enable future replacement of readline with something more modern.
Fixes #50

kenvanhyning
kenvanhyning approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@kenvanhyning kenvanhyning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactoring!

@shueybubbles shueybubbles merged commit 0fba127 into main Mar 8, 2022
@shueybubbles shueybubbles deleted the shueybubbles/connectcmd branch March 8, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenvanhyning kenvanhyning kenvanhyning approved these changes

@stuartpa stuartpa Awaiting requested review from stuartpa

@dzsquared dzsquared Awaiting requested review from dzsquared

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlcmd doesn't prompt for password when required
2 participants
@shueybubbles @kenvanhyning