Skip to content

Fix issues with special characters in files #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2023
Merged

Fix issues with special characters in files #463

merged 2 commits into from
Oct 10, 2023

Conversation

shueybubbles
Copy link
Collaborator

  • The variable substitution logic was using byte offsets instead of rune offsets. If there were double byte characters in the stream, variable values were written to the wrong place.
  • Command processing was incorrectly treating tabs as end of line

@shueybubbles shueybubbles merged commit a62432f into main Oct 10, 2023
@shueybubbles shueybubbles deleted the dev/davidshi/encodingissues branch October 10, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvdeshmukh apoorvdeshmukh apoorvdeshmukh approved these changes

@stuartpa stuartpa Awaiting requested review from stuartpa

@dlevy-msft dlevy-msft Awaiting requested review from dlevy-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shueybubbles @apoorvdeshmukh