-
Notifications
You must be signed in to change notification settings - Fork 75
Fix issues with batch and command parsing #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to fix other labels that start with commands such as Rollback_Record:
?
|
@shueybubbles SQLCMD was throwing errors for me on labels like |
OK seems to work for me on this version. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a project approver but these changes appear to fix our issues with v0.11
Looks good to me (100% code coverage for fix) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this. I know you're dealing with some license generation stuff now and the build is failing, but when you get that squared away, doing a release would be very much appreciated. Thanks for all of your hard work on robustifying go-sqlcmd to work with our legal but gross T-SQL :-) |
[]
were not being properly readexit
command had a buggy regex which matched variants likeexit_something
Fixes #197
Fixes #198