Skip to content

Build cmd/modern dir as per current dir structure #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 11, 2023
Merged

Build cmd/modern dir as per current dir structure #186

merged 6 commits into from
Jan 11, 2023

Conversation

apoorvdeshmukh
Copy link
Contributor

@apoorvdeshmukh apoorvdeshmukh commented Jan 10, 2023 •
edited
Loading

Updating pipeline to build sqlcmd from cmd/modern dir
Addresses #185

@apoorvdeshmukh apoorvdeshmukh marked this pull request as draft January 10, 2023 13:45
shueybubbles
shueybubbles reviewed Jan 10, 2023
View reviewed changes
@shueybubbles
Copy link
Collaborator

Pls add a build.sh and build.bat in the root build folder that both people and pipelines can use. Otherwise I think it's a bit confusing to figure out where to build things as a new contributor.

@shueybubbles
Copy link
Collaborator

Also move the rsrc files and winres folder from cmd/sqlcmd to modern and put the generate line in main.go

//go:generate go-winres make --file-version=git-tag --product-version=git-tag

shueybubbles
shueybubbles reviewed Jan 10, 2023
View reviewed changes
@shueybubbles shueybubbles requested a review from stuartpa January 10, 2023 14:51
shueybubbles
shueybubbles reviewed Jan 10, 2023
View reviewed changes
shueybubbles
shueybubbles reviewed Jan 10, 2023
View reviewed changes
shueybubbles
shueybubbles approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@shueybubbles shueybubbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@apoorvdeshmukh apoorvdeshmukh marked this pull request as ready for review January 10, 2023 19:15
@apoorvdeshmukh
Copy link
Contributor Author

The product build pipeline is validated in this run and is working fine.

@apoorvdeshmukh apoorvdeshmukh linked an issue Jan 11, 2023 that may be closed by this pull request
build-common.yml is still building the cmd/sqlcmd folder #185
Closed
@apoorvdeshmukh apoorvdeshmukh merged commit 3f7c4ad into main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shueybubbles shueybubbles shueybubbles approved these changes

@stuartpa stuartpa Awaiting requested review from stuartpa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build-common.yml is still building the cmd/sqlcmd folder
2 participants
@apoorvdeshmukh @shueybubbles